fix: lab view URL #173
Merged
fix: lab view URL #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
commented
Feb 26, 2024
| @@ -3,14 +3,17 @@ | |||
| * BrowserSigner to the frontend. | |||
| */ | |||
| (() => { | |||
| const rpc = (method, params) => { | |||
| const rpc = async (method, params) => { | |||
There was a problem hiding this comment.
The async here makes sure the error raises a rejected promise instead of completely failing
charles-cooper
approved these changes
Feb 26, 2024
|
please fix some lint issue and then i can merge -- https://github.com/vyperlang/titanoboa/actions/runs/8051752665/job/21990356973?pr=173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
https://try.vyperlang.org/user/{user}/lab/workspaces/auto-L/tree/{file}.ipynbinstead of the notebook URLhttps://try.vyperlang.org/user/{user}/notebooks/{file}.ipynbHow I did it
asynctorpcso the exception is displayed properlyHow to verify it
Description for the changelog
Cute Animal Picture